Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include NullableResponse<T> as an accepted response type #4512

Merged
merged 2 commits into from
Jan 31, 2023

Conversation

christothes
Copy link
Member

fixes #4444

This should pass checks once Azure.Core 1.26.0 ships.

@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label Dec 30, 2022
@ghost
Copy link

ghost commented Dec 30, 2022

Hi @christothes. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@ghost ghost closed this Jan 6, 2023
@ghost
Copy link

ghost commented Jan 6, 2023

Hi @christothes. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass.

@christothes christothes reopened this Jan 31, 2023
@christothes christothes requested a review from a team as a code owner January 31, 2023 15:24
@ghost ghost removed the no-recent-activity There has been no recent activity on this issue. label Jan 31, 2023
@christothes christothes merged commit 63c91f7 into main Jan 31, 2023
@christothes christothes deleted the chriss/nullableResponseT branch January 31, 2023 15:52
@heaths
Copy link
Member

heaths commented Jan 31, 2023

@christothes when might we see this in Azure/azure-sdk-for-net? Just looked at recent opened and closed PRs and didn't see any corresponding package updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AzureSDKAnalyzer: AZC0015 should include NullableResponse<T>
3 participants